fix screen dispotition on desktop, add yubico-pam on desktop config

Makefile

@@ -27,5 +27,5 @@ cleanup :
 	nix-env --delete-generations +1
 	sudo nix-collect-garbage -d
 
-optimise :
+optimize :
 	nix-store --optimize -vv

flake.lock

@@ -5,11 +5,11 @@
         "nixpkgs": "nixpkgs"
       },
       "locked": {
-        "lastModified": 1756741629,
+        "lastModified": 1759572023,
-        "narHash": "sha256-n+mgH3NoQf8d1jd8cDp/9Mt++hhyuE3LO3ZAxzjWRZw=",
+        "narHash": "sha256-2fzYq/m2PXie5WZO5LhyiZrTIUdUFp1SCLZAwvPL5xo=",
         "owner": "catppuccin",
         "repo": "nix",
-        "rev": "cd22197da06df1eb6fabdaa2fc22c170c4f67382",
+        "rev": "eeada12912d80d04733383d231a9d66172858718",
         "type": "github"
       },
       "original": {
@@ -26,11 +26,11 @@
       },
       "locked": {
         "dir": "pkgs/firefox-addons",
-        "lastModified": 1756958609,
+        "lastModified": 1759637032,
-        "narHash": "sha256-1nRGsnPZjOubRTsXEsnJqWlLsgo/Xq7tN7PWK57dFDQ=",
+        "narHash": "sha256-tJPZLTwVT6D8JCASuRmDov1yu9XIdC0btRlQCzCU688=",
         "owner": "rycee",
         "repo": "nur-expressions",
-        "rev": "b2a4e1bc62946403f82594ab9550ac13a1afa4df",
+        "rev": "eff82f4fb13a381248ba1432a641894b6c0e4442",
         "type": "gitlab"
       },
       "original": {
@@ -47,11 +47,11 @@
         ]
       },
       "locked": {
-        "lastModified": 1756954499,
+        "lastModified": 1759573136,
-        "narHash": "sha256-Pg4xBHzvzNY8l9x/rLWoJMnIR8ebG+xeU+IyqThIkqU=",
+        "narHash": "sha256-ILSPD0Dm8p0w0fCVzOx98ZH8yFDrR75GmwmH3fS2VnE=",
         "owner": "nix-community",
         "repo": "home-manager",
-        "rev": "ed1a98c375450dfccf427adacd2bfd1a7b22eb25",
+        "rev": "5f06ceafc6c9b773a776b9195c3f47bbe1defa43",
         "type": "github"
       },
       "original": {
@@ -62,11 +62,11 @@
     },
     "nixos-hardware": {
       "locked": {
-        "lastModified": 1756925795,
+        "lastModified": 1759582739,
-        "narHash": "sha256-kUb5hehaikfUvoJDEc7ngiieX88TwWX/bBRX9Ar6Tac=",
+        "narHash": "sha256-spZegilADH0q5OngM86u6NmXxduCNv5eX9vCiUPhOYc=",
         "owner": "NixOS",
         "repo": "nixos-hardware",
-        "rev": "ba6fab29768007e9f2657014a6e134637100c57d",
+        "rev": "3441b5242af7577230a78ffb03542add264179ab",
         "type": "github"
       },
       "original": {
@@ -78,11 +78,11 @@
     },
     "nixpkgs": {
       "locked": {
-        "lastModified": 1756266583,
+        "lastModified": 1759381078,
-        "narHash": "sha256-cr748nSmpfvnhqSXPiCfUPxRz2FJnvf/RjJGvFfaCsM=",
+        "narHash": "sha256-gTrEEp5gEspIcCOx9PD8kMaF1iEmfBcTbO0Jag2QhQs=",
         "owner": "NixOS",
         "repo": "nixpkgs",
-        "rev": "8a6d5427d99ec71c64f0b93d45778c889005d9c2",
+        "rev": "7df7ff7d8e00218376575f0acdcc5d66741351ee",
         "type": "github"
       },
       "original": {
@@ -94,11 +94,11 @@
     },
     "nixpkgs_2": {
       "locked": {
-        "lastModified": 1756787288,
+        "lastModified": 1759381078,
-        "narHash": "sha256-rw/PHa1cqiePdBxhF66V7R+WAP8WekQ0mCDG4CFqT8Y=",
+        "narHash": "sha256-gTrEEp5gEspIcCOx9PD8kMaF1iEmfBcTbO0Jag2QhQs=",
         "owner": "nixos",
         "repo": "nixpkgs",
-        "rev": "d0fc30899600b9b3466ddb260fd83deb486c32f1",
+        "rev": "7df7ff7d8e00218376575f0acdcc5d66741351ee",
         "type": "github"
       },
       "original": {
@@ -125,11 +125,11 @@
         ]
       },
       "locked": {
-        "lastModified": 1754988908,
+        "lastModified": 1759635238,
-        "narHash": "sha256-t+voe2961vCgrzPFtZxha0/kmFSHFobzF00sT8p9h0U=",
+        "narHash": "sha256-UvzKi02LMFP74csFfwLPAZ0mrE7k6EiYaKecplyX9Qk=",
         "owner": "Mic92",
         "repo": "sops-nix",
-        "rev": "3223c7a92724b5d804e9988c6b447a0d09017d48",
+        "rev": "6e5a38e08a2c31ae687504196a230ae00ea95133",
         "type": "github"
       },
       "original": {

flake.nix

@@ -6,7 +6,7 @@
 #    By: tomoron <tomoron@student.42angouleme.fr>   +#+  +:+       +#+         #
 #                                                 +#+#+#+#+#+   +#+            #
 #    Created: 2024/10/17 18:15:24 by tomoron           #+#    #+#              #
-#    Updated: 2025/09/06 00:58:57 by tomoron          ###   ########.fr        #
+#    Updated: 2025/09/24 02:10:00 by tomoron          ###   ########.fr        #
 #                                                                              #
 # **************************************************************************** #
 
@@ -51,9 +51,9 @@
 		];
       };
 
-	  homeConfig = {flakeName, extraModules ? [], username ? "tom", homeDir ? "/home/tom"}: home-manager.lib.homeManagerConfiguration {
+	  homeConfig = {flakeName, sops ? true, extraModules ? [], username ? "tom", homeDir ? "/home/tom"}: home-manager.lib.homeManagerConfiguration {
         inherit pkgs;
-	    extraSpecialArgs = { inherit inputs; username = username; homeDir = homeDir; isOs = false; };
+	    extraSpecialArgs = { inherit inputs; username = username; homeDir = homeDir; isOs = false; configSops = sops; };
         modules = nixpkgs.lib.concatLists [
 		  [
 		    ./homeConfigs/home.nix
@@ -85,8 +85,8 @@
 
 
       homeConfigurations = {
-	    vbox = homeConfig { flakeName = "vbox"; };
+	    vbox = homeConfig { flakeName = "vbox";};
-	    ft = homeConfig { flakeName = "ft"; username = "tomoron"; homeDir = "/home/tomoron";};
+	    ft = homeConfig { flakeName = "ft"; username = "tomoron"; homeDir = "/home/tomoron"; sops = false;};
 	    laptop = homeConfig { flakeName = "laptop"; };
 	    desktop = homeConfig { flakeName = "desktop"; };
 	    server = homeConfig { flakeName = "server"; };

homeConfigs/global/appearance.nix

@@ -0,0 +1,33 @@
+{ lib, pkgs, ... }:
+{
+  catppuccin = {
+  	enable = true;
+	flavor = "mocha";
+
+	dunst.enable = true;
+	dunst.flavor="frappe";
+
+    kvantum.apply = true;
+    rofi.enable = false;
+  };
+
+  gtk = {
+    enable = true;
+    theme = { package = pkgs.flat-remix-gtk; name = "Flat-Remix-GTK-Grey-Darkest"; };
+    font = { name = "Sans"; size = 11; };
+  };
+
+  qt.style.name = "kvantum";
+
+  home.pointerCursor = {
+    gtk.enable = true;
+    package = pkgs.bibata-cursors;
+    name = "Bibata-Modern-Classic";
+    size = 16;
+  };
+
+  home.file = {
+    ".config/wallpaper.png".source = lib.mkDefault ../utils/wallpaper.png;
+    ".config/lock_screen.jpg".source = lib.mkDefault ../utils/lock_screen.jpg;
+  };
+}

homeConfigs/global/catppuccin.nix

@@ -0,0 +1,13 @@
+{ ... }:
+{
+  catppuccin = {
+  	enable = true;
+	flavor = "mocha";
+
+	dunst.enable = true;
+	dunst.flavor="frappe";
+
+    kvantum.apply = true;
+    rofi.enable = false;
+  };
+}

homeConfigs/global/fileManager.nix

@@ -0,0 +1,16 @@
+{ ... }: 
+{
+  programs.yazi = {
+    enable = true;
+	settings.mgr.sort_dir_first=false;
+  };
+  programs.bash.bashrcExtra = ''
+    function y() {
+      local tmp="$(mktemp -t "yazi-cwd.XXXXXX")" cwd
+      yazi "$@" --cwd-file="$tmp"
+      IFS= read -r -d "" cwd < "$tmp"
+      [ -n "$cwd" ] && [ "$cwd" != "$PWD" ] && builtin cd -- "$cwd"
+      rm -f -- "$tmp"
+    }
+  '';
+}

homeConfigs/global/rclone.nix

@@ -0,0 +1,21 @@
+{ config, homeDir, ... }:
+{
+  programs.rclone.enable = true;
+  sops.secrets."nextcloud_fuse/password" = {};
+  programs.rclone.remotes.nextcloud = {
+    config = {
+	  type = "webdav";
+	  url = "https://nc.tmoron.fr/remote.php/dav/files/tom";
+	  vendor = "nextcloud";
+	  user = "tom";
+    };
+	secrets.pass = config.sops.secrets."nextcloud_fuse/password".path;
+	mounts = {
+	  "/" = {
+	    enable = true;
+		mountPoint = "${homeDir}/nextcloud";
+		options.vfs-cache-mode = "writes";
+	  };
+	};
+  };
+}

homeConfigs/global/rofi.nix

@@ -0,0 +1,13 @@
+{ ... }:
+{
+  programs.rofi = {
+    enable = true;
+	theme = "rounded-nord-dark";
+  };
+
+  home.file.".local/share/rofi/themes".source = "${builtins.fetchGit {
+  	url = "https://github.com/newmanls/rofi-themes-collection";
+  	rev = "c8239a45edced3502894e1716a8b661fdea8f1c9";
+  	ref = "master";
+  }}/themes";
+}

homeConfigs/global/shell.nix

@@ -0,0 +1,20 @@
+{ ... }:
+{
+  home.shell.enableBashIntegration = true;
+  home.shellAliases = {
+    ls= "ls --color=auto";
+    grep = "grep --color=auto";
+    vim = "nvim";
+    vi = "nvim";
+    hl = "Hyprland";
+    clr = "clear";
+	noidle = "systemctl --user stop hypridle";
+  };
+  
+  programs.bash = {
+	enable = true;
+    historyControl = ["ignoreboth"];
+	historyIgnore = [ "ls" "cd" "exit" ];
+	shellOptions = [ "cdspell" "autocd"];
+  };
+}

homeConfigs/home.nix

@@ -6,16 +6,24 @@
 #    By: tomoron <tomoron@student.42angouleme.fr>   +#+  +:+       +#+         #
 #                                                 +#+#+#+#+#+   +#+            #
 #    Created: 2024/10/17 18:15:38 by tomoron           #+#    #+#              #
-#    Updated: 2025/09/17 18:18:51 by tomoron          ###   ########.fr        #
+#    Updated: 2025/09/24 02:08:41 by tomoron          ###   ########.fr        #
 #                                                                              #
 # **************************************************************************** #
 
-{lib, pkgs, config, username ? "tom" ,homeDir ? "/home/tom", isOs ? false, ... }:
+{
+lib,
+username ? "tom",
+homeDir ? "/home/tom",
+isOs ? false,
+configSops ? true,
+... 
+}:
 
 {
   imports = lib.concatLists [
     [ ./packages.nix ]
     (lib.fileset.toList ./modules)
+    (lib.fileset.toList ./global)
   ];
 
   home.username = lib.mkIf (!isOs) "${username}";
@@ -23,94 +31,11 @@
 
   home.stateVersion = "24.05";
 
-  sops.defaultSopsFile = ../secrets/secrets.yaml;
+  sops = lib.mkIf configSops{
-  sops.age.keyFile = "${homeDir}/.config/sops/age/keys.txt";
+    defaultSopsFile = ../secrets/secrets.yaml;
-  sops.secrets."nextcloud_fuse/password" = {};
+    age.keyFile = "${homeDir}/.config/sops/age/keys.txt";
-
-  programs.rclone.enable = true;
-  programs.rclone.remotes.nextcloud = {
-    config = {
-	  type = "webdav";
-	  url = "https://nc.tmoron.fr/remote.php/dav/files/tom";
-	  vendor = "nextcloud";
-	  user = "tom";
-    };
-	secrets.pass = config.sops.secrets."nextcloud_fuse/password".path;
-	mounts = {
-	  "/" = {
-	    enable = true;
-		mountPoint = "${homeDir}/nextcloud";
-		options.vfs-cache-mode = "writes";
-	  };
-	};
   };
 
-#  programs.ghostty.enable = true;
-#  programs.ghostty.settings = {
-#    theme = "catppuccin-mocha";
-#	font-size = 9;
-#  };
-
-  home.pointerCursor = {
-    gtk.enable = true;
-    package = pkgs.bibata-cursors;
-    name = "Bibata-Modern-Classic";
-    size = 16;
-  };
-
-  gtk = {
-    enable = true;
-    theme = { package = pkgs.flat-remix-gtk; name = "Flat-Remix-GTK-Grey-Darkest"; };
-#    iconTheme = { package = pkgs.adwaita-icon-theme; name = "Adwaita"; };
-    font = { name = "Sans"; size = 11; };
-  };
-
-  home.shellAliases = {
-    ls= "ls --color=auto";
-    grep = "grep --color=auto";
-    vim = "nvim";
-    vi = "nvim";
-    hl = "Hyprland";
-    clr = "clear";
-#    tagueule = "asusctl profile -P Quiet";
-#    parle = "asusctl profile -P performance";
-	noidle = "systemctl --user stop hypridle";
-  };
-  
-  programs.bash = {
-	enable = true;
-    historyControl = ["ignoreboth"];
-	historyIgnore = [ "ls" "cd" "exit" ];
-	shellOptions = [ "cdspell" "autocd"];
-  };
-
-  home.sessionPath = [ "~/.local/bin" ];
-
-
-  home.file = { #should be able to make most of these in nix configs 
-    ".config/wallpaper.png".source = lib.mkDefault utils/wallpaper_test.png;
-    ".config/pc.jpg".source = lib.mkDefault utils/pc.jpg;
-  	".config/rofi/config.rasi".text = "@theme \"rounded-nord-dark.rasi\"";
-
-	".local/share/rofi/themes".source = "${builtins.fetchGit {
-		url = "https://github.com/newmanls/rofi-themes-collection";
-		rev = "c8239a45edced3502894e1716a8b661fdea8f1c9";
-		ref = "master";
-    }}/themes";
-
-  };
   services.dunst.enable = true;
-
   programs.home-manager.enable = true;
-
-  qt.style.name = "kvantum";
-  catppuccin.kvantum.apply = true;
-
-  catppuccin = {
-  	enable = true;
-	flavor = "mocha";
-
-	dunst.enable = true;
-	dunst.flavor="frappe";
-  };
 }

homeConfigs/hosts/desktop.nix

@@ -4,10 +4,10 @@
   mods.x11.enable = true;
   wayland.windowManager.hyprland.settings = {
     monitor = [
-	  "HDMI-A-1, 1920x1080@60, 0x0, auto"
+	  "DP-1, 1280x1024@75.03Hz, 0x0, auto"
-      "HDMI-A-3, 1920x1080@60, 1920x0, auto"
+      "HDMI-A-1, 1920x1080@60, 1280x0, auto"
-	  "DP-1, 1280x1024@60, 3840x0, auto"
+	  "HDMI-A-3, 1920x1080@74.97Hz, 3200x0, auto"
-	  "DP-3, 1280x1024@60, 5120x0, auto"
+	  "DP-3, 1920x1080@60.00Hz, 5120x0, auto"
     ];
 	workspace = [
       "1, monitor:HDMI-A-1"

homeConfigs/modules/game.nix

@@ -13,6 +13,8 @@
 	  mangohud
 	  moonlight-qt
 	  prismlauncher
+
+	  r2modman
 	];
   };
 }

homeConfigs/modules/git.nix

@@ -19,6 +19,8 @@
       	push.autoSetupRemote = true;
 		rerere.enabled = true;
 		help.autocorrect = 1;
+		user.signingkey = "251B4BD73683A8DF13D760A868BFAFE31DF313AD";
+		commit.gpgsign = true;
       };
       aliases = {
         fuck = "!f() { git reset --hard \"@{upstream}\" && git restore . && git clean -f .; };f";

homeConfigs/modules/vim.nix

@@ -29,7 +29,8 @@
       autocmd BufWinEnter *.* silent! loadview
       set tabstop=4
       set scrolloff=10
-      set preserveindent
+      set smartindent 
+	  set shiftwidth=4
       map <silent> <C-N> :bnext<CR>
       map <silent> <C-P> :bprevious<CR>
       nmap <silent> <c-k> :wincmd k<CR>
@@ -68,8 +69,8 @@
       lua require'lspconfig'.clangd.setup{}
       lua require'lspconfig'.nixd.setup{}
       lua require'lspconfig'.glsl_analyzer.setup{}
-      set signcolumn=no
+      set signcolumn=auto
-      
+
       nnoremap <leader>ff <cmd>Telescope find_files<cr>
       nnoremap <leader>fg <cmd>Telescope live_grep<cr>
       nnoremap <leader>fb <cmd>Telescope buffers<cr>

homeConfigs/modules/wayland/hyprland.nix

@@ -10,11 +10,14 @@
   config = lib.mkIf config.mods.hyprland.enable {
     wayland.windowManager.hyprland.systemd.variables = [ "--all" ];
 
+	programs.hyprshot.enable = true;
+
     wayland.windowManager.hyprland.enable = true;
     wayland.windowManager.hyprland.settings = {
       "$mainMod" = "SUPER";
       bind = [
-  	  " , Print, exec, grim -t png -g \"$(slurp)\" /dev/stdout | tee ~/screenshots/$(date +%Y-%m-%d_%H-%m-%s).png | wl-copy -t image/png"
+  	    " , Print, exec, hyprshot -m region -o ~/screenshots -f $(date +%Y-%m-%d_%H-%M-%S).png"
+  	    " SHIFT, Print, exec, hyprshot -m output -m active -o ~/screenshots -f $(date +%Y-%m-%d_%H-%M-%S).png" 
         "$mainMod, Return, exec, alacritty"
         "CTRL_ALT, Q, killactive,"
         "CTRL_ALT_SHIFT, Q, forcekillactive,"
@@ -22,6 +25,7 @@
         "$mainMod, S, togglefloating,"
         "$mainMod, I, pin,"
         "$mainMod, D, exec, rofi -show drun -show-icons"
+        "$mainMod SHIFT, D, exec, rofi -show run -show-icons"
         "$mainMod, M, fullscreen, 1"
         "$mainMod, F, fullscreen, 0"
   
@@ -163,6 +167,8 @@
         allow_tearing = false;
         layout = "dwindle";
       };
+
+	  layerrule = "noanim, selection";
   
   	  cursor.no_warps = true;
   

homeConfigs/modules/wayland/packages.nix

@@ -3,7 +3,6 @@
 {
   config = lib.mkIf config.mods.hyprland.enable {
     home.packages = with pkgs; [
-      rofi-wayland
 	  grim
 	  slurp
 	  wl-clipboard

osConfigs/hosts/desktop.nix

@@ -6,7 +6,7 @@
 #    By: tomoron <tomoron@student.42angouleme.fr>   +#+  +:+       +#+         #
 #                                                 +#+#+#+#+#+   +#+            #
 #    Created: 2025/09/06 00:57:04 by tomoron           #+#    #+#              #
-#    Updated: 2025/09/06 00:57:05 by tomoron          ###   ########.fr        #
+#    Updated: 2025/10/26 00:59:12 by tomoron          ###   ########.fr        #
 #                                                                              #
 # **************************************************************************** #
 
@@ -22,6 +22,7 @@
   networking.hostName = "nixos-fixe";
 
   hardware.cpu.intel.updateMicrocode = true;
+  mods.yubikey.pam.enable = true;
 
   boot.kernelModules = [ "kvm-intel" "nvidia" ];
   mods.displayManager.enable = true;

osConfigs/hosts/laptop.nix

@@ -6,11 +6,11 @@
 #    By: tomoron <tomoron@student.42angouleme.fr>   +#+  +:+       +#+         #
 #                                                 +#+#+#+#+#+   +#+            #
 #    Created: 2025/09/06 00:56:57 by tomoron           #+#    #+#              #
-#    Updated: 2025/09/17 18:46:28 by tomoron          ###   ########.fr        #
+#    Updated: 2025/10/11 00:23:01 by tomoron          ###   ########.fr        #
 #                                                                              #
 # **************************************************************************** #
 
-{ config, pkgs, ... }:
+{ lib, config, pkgs, ... }:
 
 {
   boot.initrd.luks.yubikeySupport = true;
@@ -32,6 +32,7 @@
   };
 
   boot.blacklistedKernelModules = [ "nvidia" "nvidia_drm" "nvidia_uvm" ]; #speeds up startup
+  programs.droidcam.enable = true;
 
   mods.displayManager.enable = true;
   mods.virtualHost.enable = true;
@@ -64,6 +65,7 @@
         SUBSYSTEM=="kvmfr", OWNER="tom", GROUP="kvm", MODE="0660"
     '';
     environment.systemPackages = with pkgs; [ looking-glass-client ];
+    services.supergfxd.settings.mode = "Vfio";
   };
 
   networking.dhcpcd.enable = false;
@@ -79,16 +81,23 @@
 
   mods.touchpad.enable = true;
 
-  mods.powerSave.enable = true;
+  programs.gamescope.enable = true;
-  mods.powerSave.powahCommandAdditions = [
+#  programs.gamescope.capSysNice = true;
-    "supergfxctl -m Hybrid"
+
-    "if asusctl profile -p | grep Balanced ; then asusctl profile -P Performance; fi"
+  mods.powerSave = {
-    "if asusctl profile -p | grep Quiet ; then asusctl profile -P Balanced; fi"
+    enable = true;
-  ];
+    powahCommandAdditions = [
-  mods.powerSave.tagueuleCommandAdditions = [
+      "supergfxctl -m Hybrid"
-    "echo \"can't safely turn off the GPU\""
+      "if asusctl profile -p | grep Balanced ; then asusctl profile -P Performance; fi"
-	"asusctl profile -P Quiet"
+      "if asusctl profile -p | grep Quiet ; then asusctl profile -P Balanced; fi"
-  ];
+    ];
+    tagueuleCommandAdditions = [
+      "echo \"can't safely turn off the GPU\""
+      "asusctl profile -P Quiet"
+    ];
+	cpuMaxFreq = 4465261;
+
+  };
 
   services.asusd = {
     enable = true;
@@ -97,7 +106,7 @@
 
   services.supergfxd.enable = true;
   services.supergfxd.settings = {
-    mode = "Integrated";
+    mode = lib.mkDefault "Integrated";
     vfio_enable = true;
     vfio_save = true;
     always_reboot = false;
@@ -115,7 +124,7 @@
   mods.nvidia.prime = true;
 
 
-#  services.usbmuxd.enable = true; #hangs when shutting down
+  services.usbmuxd.enable = true; #hangs when shutting down
 
 #  boot.plymouth = {
 #    enable = true;

osConfigs/modules/powerSave.nix

@@ -6,7 +6,7 @@
 #    By: tomoron <tomoron@student.42angouleme.fr>   +#+  +:+       +#+         #
 #                                                 +#+#+#+#+#+   +#+            #
 #    Created: 2025/09/06 00:45:04 by tomoron           #+#    #+#              #
-#    Updated: 2025/09/17 18:47:27 by tomoron          ###   ########.fr        #
+#    Updated: 2025/09/23 04:25:20 by tomoron          ###   ########.fr        #
 #                                                                              #
 # **************************************************************************** #
 
@@ -19,6 +19,7 @@
       default = false;
       description = "enable services and settings to save power";
     };
+
     powahCommandAdditions = lib.mkOption {
       type = lib.types.listOf lib.types.str;
       default = [];
@@ -29,6 +30,41 @@
       default = [];
       description = "commands the `tagueule` script runs";
     };
+
+    pStateCompatible = lib.mkOption {
+	  type = lib.types.bool;
+	  default = false;
+	  description = "is the cpu p-state compatible. only most of intel cpu's";
+	};
+
+    cpuMaxFreq = lib.mkOption {
+	  type = lib.types.ints.positive;
+	  default = 5000000;
+	  description = "the max frequency of the cpu (in KHz)";
+	};
+
+	governorPowers = {
+      ac.min = lib.mkOption {
+	    type = lib.types.ints.unsigned;
+	    default = 30;
+	    description = "min frequency on AC";
+	  };
+      ac.max = lib.mkOption {
+	    type = lib.types.ints.unsigned;
+	    default = 100;
+	    description = "max frequency on AC";
+	  };
+      bat.min = lib.mkOption {
+	    type = lib.types.ints.unsigned;
+	    default = 0;
+	    description = "min frequency on BAT";
+	  };
+      bat.max = lib.mkOption {
+	    type = lib.types.ints.unsigned;
+	    default = 40;
+	    description = "max frequency on BAT";
+	  };
+	};
   };
 
 
@@ -44,12 +80,19 @@
     
         CPU_ENERGY_PERF_POLICY_ON_BAT = "power";
         CPU_ENERGY_PERF_POLICY_ON_AC = "performance";
-    
+      }
-        CPU_MIN_PERF_ON_AC = 0;
+	  // lib.optionalAttrs (!config.mods.powerSave.pStateCompatible) (with config.mods.powerSave; {
-        CPU_MAX_PERF_ON_AC = 100;
+        CPU_SCALING_MIN_FREQ_ON_AC  = (cpuMaxFreq * governorPowers.ac.min) / 100;
-        CPU_MIN_PERF_ON_BAT = 0;
+        CPU_SCALING_MAX_FREQ_ON_AC  = (cpuMaxFreq * governorPowers.ac.max) / 100;
-        CPU_MAX_PERF_ON_BAT = 20;
+        CPU_SCALING_MIN_FREQ_ON_BAT = (cpuMaxFreq * governorPowers.bat.min) / 100;
-      };
+        CPU_SCALING_MAX_FREQ_ON_BAT = (cpuMaxFreq * governorPowers.bat.max) / 100;
+      }) 
+	  // lib.optionalAttrs config.mods.powerSave.pStateCompatible (with config.mods.powerSave.governorPowers; {
+	    CPU_MIN_PERF_ON_AC = ac.min;
+        CPU_MAX_PERF_ON_AC = ac.max;
+        CPU_MIN_PERF_ON_BAT = bat.min;
+        CPU_MAX_PERF_ON_BAT = bat.max;
+	  });
     };
 
 	environment.systemPackages = [
@@ -57,11 +100,10 @@
 	    name = "powah";
 	    runtimeInputs = with pkgs; [ tlp ];
 	    text = ''
-	    if [[ $EUID -ne 0 ]]; then
+	      if [[ $EUID -ne 0 ]]; then
-           echo "This script must be run as root" 
+            exec sudo bash "$0" "$@"
-           exit 1
+          fi
-        fi
+		  tlp ac
-		tlp ac
         '' + lib.concatStringsSep "\n" config.mods.powerSave.powahCommandAdditions;
         })
 
@@ -69,17 +111,15 @@
 	    name = "tagueule";
 	    runtimeInputs = with pkgs; [ tlp ];
 	    text = ''
-	    if [[ $EUID -ne 0 ]]; then
+	      if [[ $EUID -ne 0 ]]; then
-           echo "This script must be run as root" 
+            exec sudo bash "$0" "$@"
-           exit 1
+          fi
-        fi
+		  tlp bat
-		tlp bat
         '' + lib.concatStringsSep "\n" config.mods.powerSave.tagueuleCommandAdditions;
         })
     ];
 
     powerManagement.enable = true;
-    services.upower.enable = true;
     mods.nvidia.prime = true;
   };
 }